8000 Fix the test for casting FlattenException on Windows by stof · Pull Request #49940 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix the test for casting FlattenException on Windows #49940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2023
Merged

Fix the test for casting FlattenException on Windows #49940

merged 1 commit into from
Apr 5, 2023

Conversation

stof
Copy link
Member
@stof stof commented Apr 5, 2023
Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

The assertion should avoid forcing to show path separators, as done in other tests of the caster, as path separators are different on Windows.
This fixes the test introduced in #49853

@stof
Fix the test for casting FlattenException on Windows 8000
1464e1e 
The assertion should avoid forcing to show path separators, as done in
other tests of the caster, as path separators are different on Windows.
@carsonbot carsonbot added this to the 6.3 milestone Apr 5, 2023
chalasr
chalasr approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member
@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@chalasr
Copy link
Member
chalasr commented Apr 5, 2023

Thank you @stof.

@chalasr chalasr merged commit 6be3b71 into symfony:6.3 Apr 5, 2023
@stof stof deleted the fix_windows_tests branch April 6, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@stof @chalasr @nicolas-grekas @carsonbot
0