10000 [Mailer] Return-Path has higher priority for envelope address than From address by tpetry · Pull Request #45992 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Mailer] Return-Path has higher priority for envelope address than From address #45992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2022
Merged

[Mailer] Return-Path has higher priority for envelope address than From address #45992

merged 1 commit into from
Apr 12, 2022

Conversation

tpetry
Copy link
Contributor
@tpetry tpetry commented Apr 11, 2022 •
edited
Loading
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #41322
License MIT
Doc PR -

@carsonbot carsonbot added this to the 6.0 milestone Apr 11, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@tpetry tpetry force-pushed the return-path-priority branch from b2e75df to 4c98940 Compare April 11, 2022 10:24
@fabpot
Copy link
Member
fabpot commented Apr 11, 2022

This should be on 4.4 instead.