fix: return-path has higher priority for envelope address than from address (fixes #41322)

tpetry · tpetry · commit b2e75df62fa8 · 2022-04-11T12:09:03.000+02:00
diff --git a/src/Symfony/Component/Mailer/DelayedEnvelope.php b/src/Symfony/Component/Mailer/DelayedEnvelope.php
@@ -86,12 +86,12 @@ private static function getSenderFromHeaders(Headers $headers): Address
         if ($sender = $headers->get('Sender')) {
             return $sender->getAddress();
         }
-        if ($from = $headers->get('From')) {
-            return $from->getAddresses()[0];
-        }
         if ($return = $headers->get('Return-Path')) {
             return $return->getAddress();
         }
+        if ($from = $headers->get('From')) {
+            return $from->getAddresses()[0];
+        }
 
         throw new LogicException('Unable to determine the sender of the message.');
     }
diff --git a/src/Symfony/Component/Mailer/Tests/EnvelopeTest.php b/src/Symfony/Component/Mailer/Tests/EnvelopeTest.php
@@ -113,7 +113,7 @@ public function testSenderFromHeadersWithMulitpleHeaders()
         $headers->addPathHeader('Return-Path', $return = new Address('return@symfony.com', 'return'));
         $headers->addMailboxListHeader('To', ['to@symfony.com']);
         $e = Envelope::create(new Message($headers));
-        $this->assertEquals($from, $e->getSender());
+        $this->assertEquals($return, $e->getSender());
     }
 
     public function testRecipientsFromHeaders()

Original file line number	Diff line number	Diff line change
`@@ -86,12 +86,12 @@ private static function getSenderFromHeaders(Headers $headers): Address`
`86`	`86`	`if ($sender = $headers->get('Sender')) {`
`87`	`87`	`return $sender->getAddress();`
`88`	`88`	`}`
`89`		`- if ($from = $headers->get('From')) {`
`90`		`- return $from->getAddresses()[0];`
`91`		`- }`
`92`	`89`	`if ($return = $headers->get('Return-Path')) {`
`93`	`90`	`return $return->getAddress();`
`94`	`91`	`}`
	`92`	`+ if ($from = $headers->get('From')) {`
	`93`	`+ return $from->getAddresses()[0];`
	`94`	`+ }`
`95`	`95`
`96`	`96`	`throw new LogicException('Unable to determine the sender of the message.');`
`97`	`97`	`}`
Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ public function testSenderFromHeadersWithMulitpleHeaders()`
`113`	`113`	`$headers->addPathHeader('Return-Path', $return = new Address('return@symfony.com', 'return'));`
`114`	`114`	`$headers->addMailboxListHeader('To', ['to@symfony.com']);`
`115`	`115`	`$e = Envelope::create(new Message($headers));`
`116`		`- $this->assertEquals($from, $e->getSender());`
	`116`	`+ $this->assertEquals($return, $e->getSender());`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`public function testRecipientsFromHeaders()`