8000 fix: return-path has higher priority for envelope address than from a… · symfony/symfony@4945059 · GitHub
[go: up one dir, main page]

Skip to content

Commit 4945059

Browse files
committed
fix: return-path has higher priority for envelope address than from address (fixes #41322)
1 parent 69f7f6e commit 4945059

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/Symfony/Component/Mailer/DelayedEnvelope.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,12 +86,12 @@ private static function getSenderFromHeaders(Headers $headers): Address
8686
if ($sender = $headers->get('Sender')) {
8787
return $sender->getAddress();
8888
}
89-
if ($from = $headers->get('From')) {
90-
return $from->getAddresses()[0];
91-
}
9289
if ($return = $headers->get('Return-Path')) {
9390
return $return->getAddress();
9491
}
92+
if ($from = $headers->get('From')) {
93+
return $from->getAddresses()[0];
94+
}
9595

9696
throw new LogicException('Unable to determine the sender of the message.');
9797
}

src/Symfony/Component/Mailer/Tests/EnvelopeTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,19 +84,19 @@ public function testSenderFromHeadersWithoutFrom()
8484
public function testSenderFromHeadersWithMulitpleHeaders()
8585
{
8686
$headers = new Headers();
87-
$headers->addMailboxListHeader('From', [$from = new Address('from@symfony.com', 'from'), 'some@symfony.com']);
88-
$headers->addPathHeader('Return-Path', $return = new Address('return@symfony.com', 'return'));
87+
$headers->addMailboxListHeader('From', [new Address('from@symfony.com', 'from'), 'some@symfony.com']);
88+
$headers->addPathHeader('Return-Path', new Address('return@symfony.com', 'return'));
8989
$headers->addMailboxHeader('Sender', $sender = new Address('sender@symfony.com', 'sender'));
9090
$headers->addMailboxListHeader('To', ['to@symfony.com']);
9191
$e = Envelope::create(new Message($headers));
9292
$this->assertEquals($sender, $e->getSender());
9393

9494
$headers = new Headers();
95-
$headers->addMailboxListHeader('From', [$from = new Address('from@symfony.com', 'from'), 'some@symfony.com']);
95+
$headers->addMailboxListHeader('From', [new Address('from@symfony.com', 'from'), 'some@symfony.com']);
9696
$headers->addPathHeader('Return-Path', $return = new Address('return@symfony.com', 'return'));
9797
$headers->addMailboxListHeader('To', ['to@symfony.com']);
9898
$e = Envelope::create(new Message($headers));
99-
$this->assertEquals($from, $e->getSender());
99+
$this->assertEquals($return, $e->getSender());
100100
}
101101

102102
public function testRecipientsFromHeaders()

0 commit comments

Comments
 (0)
0