8000 [TwigBundle] fix auto-enabling assets/expression/routing/yaml/workflow extensions by nicolas-grekas · Pull Request #43801 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[TwigBundle] fix auto-enabling assets/expression/routing/yaml/workflow extensions #43801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2021
Merged

[TwigBundle] fix auto-enabling assets/expression/routing/yaml/workflow extensions #43801

merged 1 commit into from
Oct 28, 2021

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #41672
License MIT
Doc PR -

Since there is no config option to force-enable those extension, we cannot register them conditionally using $container::willBeAvailable().

(As a general rule of thumb, $container::willBeAvailable() should not be used in a compiler pass.)

@carsonbot carsonbot added this to the 5.3 milestone Oct 28, 2021
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 28, 2021
Closed
@nicolas-grekas nicolas-grekas merged commit 66fcfba into symfony:5.3 Oct 28, 2021
@fabpot fabpot mentioned this pull request Oct 29, 2021
Merged
@nicolas-grekas nicolas-grekas deleted the twigb-check branch October 29, 2021 16:15
@Nek- Nek- mentioned this pull request Nov 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceruto yceruto yceruto approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed TwigBundle
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @yceruto @chalasr @carsonbot
0