Fixing test suite #59
Conversation
|
Thank you for this, @Nek-. The v2 of this plugin will not be maintained a short period after v3 is released (at least only security fixes), so if you see any improvements on v3 we would appreciate this also :) |
|
@loevgaard the v3 has some issues in common (ie test suite not compatible with PHP 8 because of unused dev dependencies or too old dependencies (like sylius 1.7)) this is why I'm looking into updating both versions. But there's also the tag bundle to update (I'll send some work tomorrow about it). I see the test suite is not passing yet, be sure I will fix it! |
dfebafc to
b55a8f1
Compare
b55a8f1 to
9e35ee8
Compare
|
I am sorry I do not understand why psalm do not pass on the CI and I can't suppress issue with ECS... I really do not understand how this package work. It seems like it should work with the following configuration, but without having it as a dependency I can't understand how it could work. <?php
declare(strict_types=1);
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
return static function (ContainerConfigurator $containerConfigurator): void {
$containerConfigurator->import(__DIR__ . '/vendor/setono/coding-standard/easy-coding-standard.php');
};☝️ missing on this package to allow ECS to work? But how can it work without setono/coding-standard as dependency ? But this package conflicts with sylius/coding-standard ?! |
|
My hotfix can be removed: symfony/symfony#43801 |
9e35ee8 to
085aaa3
Compare
|
@loevgaard I SEE GREEN. 🙈 (finally) commits are all annotated with details |
tests/Application/config/packages/lexik_jwt_authentication.yaml
Outdated
Show resolved
Hide resolved
|
Just a few comments, else it's a good job 🎉 |
This is the only way to test with PHP 8.x and Symfony 5.
symfony/symfony#41672 is blocking to update the behat test suite. This is why I decided to add this patch. It should not have any specific impact but for the dev environment. After the issue has been closed on Symfony side, this commit has been edited and is now a simple line 🎉
This commit also fixes some CS issues. Please notice that this configuration is coming from the setono feed bundle.
This commit fixes the following problems: 1. The script inside composer.json was failing because on Github Action it runs with SH and not BASH (fixed by making it external) 2. Since we run Symfony 5.x, we need to adapt the psalm configuration of the Symfony plugin.
093fed2 to
03064e1
Compare
|
@loevgaard updated! :) |
|
Thank you, @Nek-. Great job 🎉 |
|
@loevgaard do you want me to forward commits to 3.x branch? |
|
@Nek-: |
Hello there, trying to help to move forward.
This PR removes the test suite for PHP 8.0 because the dev dependencies are just not compatible with PHP 8.0.
It updates Sylius version to 1.10 and fixes behat tests.
It also allow to update to Symfony 5.3 thanks to the removal of the usage of
symfony/event-dispatcher-contractsin favor ofsymfony/contracts.Work is split in many commits to help you review with ease.
This PR targets 2.x but I plan to make it also on 3.x branch. Please send feedbacks!
Feel free to add
hacktoberfest-acceptedto help me complete my hacktoberfest challenge 😊 .