[TwigBundle] fix asset package availability detection #43791
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the package assets is available in the dependencies, Symfony will enable automatically assets. Otherwise assets are disabled. The problem is that sometimes you want to explicetely enable assets features (in the case of testing an application you may have assets as **dev** dependency). In the case assets are enable explicitely, the service assets.packages is defined and we should not remove the definition twig.extension.assets.
|
Closing in favor of #43801, thanks for providing more insights on the topic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #41672 . It actually fixes it for the asset package. I've no idea if there are other impacts and how to reproduce them.