8000 [WebLink] fix types on Link::withAttribute() by nicolas-grekas · Pull Request #41763 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[WebLink] fix types on Link::withAttribute() #41763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #40126
License MIT
Doc PR -

Related to php-fig/link-util@10e5234

@nicolas-grekas nicolas-grekas merged commit f0bb3ca into symfony:4.4 Jun 22, 2021
@nicolas-grekas nicolas-grekas deleted the weblink-types branch June 22, 2021 07:36
@@ -46,7 +46,7 @@ class Link implements EvolvableLinkInterface
private $rel = [];

/**
* @var string[]
* @var array<string, string|bool|string[]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: On 6.0, this change collided with #41507. I've picked the version from this PR, to make the type consistent across the branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0