[WebLink] fix types on Link::withAttribute() #41763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Jun 21, 2021
dunglas
approved these changes
Jun 21, 2021
norkunas
reviewed
Jun 22, 2021
8401c87 to
29903e2
Compare
derrabus
reviewed
Jun 22, 2021
| @@ -46,7 +46,7 @@ class Link implements EvolvableLinkInterface | |||
| private $rel = []; | |||
|
|
|||
| /** | |||
| * @var string[] | |||
| * @var array<string, string|bool|string[]> | |||
There was a problem hiding this comment.
Note: On 6.0, this change collided with #41507. I've picked the version from this PR, to make the type consistent across the branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to php-fig/link-util@10e5234