8000 Inconsistent docblock in web-link / Link.php · Issue #40126 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content
Inconsistent docblock in web-link / Link.php #40126
Closed
@Punk-UnDeaD

Description

@Punk-UnDeaD

Symfony version(s) affected: 4.4.* | 5.*

Description
Link.php implements EvolvableLinkInterface and override withAttribute(string $attribute, string $value) by withAttribute($attribute, $value), $value can by mixed now, but in docblock still string.
Child can extend parent param types and all work ok, but phpstan report error when I use withAttribute('crossorigin', true).

HttpHeaderSerializer support not only string.
twig-bridge docblock contain info about supporting true and real values.

We need update docblock to actual.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0