-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[WebLink] Added missing types #41507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Q | A |
---|---|
Branch? | 6.0 |
Bug fix? | no |
New feature? | no |
Deprecations? | no |
Tickets | - |
License | MIT |
Doc PR |
@@ -134,7 +134,7 @@ public function withoutRel($rel) | |||
* | |||
* @return static | |||
*/ | |||
public function withAttribute($attribute, $value) | |||
public function withAttribute(string $attribute, string|\Stringable|int|float|bool|array $value) | |||
{ | |||
$that = clone $this; | |||
$that->attributes[$attribute] = $value; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets update the type for the $attribute
property too. It currently says it should be an array of strings.
Thank you. I see this error on Travis:
It is the same issue as this: https://3v4l.org/uM5S9 Let's update |
Done |
@@ -20,7 +20,7 @@ | |||
}, | |||
"require": { | |||
"php": ">=8.0.2", | |||
"psr/link": "^1.0" | |||
"psr/link": "^1.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we add a conflict rule for ext-psr
? If we bump here, the component will break if (any released version of) ext-psr
is installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't care, that's not our problem
154b75b
to
7193557
Compare
Thank you @tarlepp. |