Add 'form-control-range' for range input type #40422
Conversation
Add 'form-control-range' for range input type.
Apudate bootstrap range test
|
I finished my 4 month old pull request: #38625 |
|
Hey! Excellent, just like I would have done it. I think @AngelFQC has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
Yes there are some failed builds and I don't know to fix that (it's my first pull request) |
There was a problem hiding this comment.
This fails when generating trailing spaces, for example here:
Expected
-'<input type="text" id="text" name="text" disabled="disabled" required="required" readonly="readonly" maxlength="10" pattern="\d+" class="foobar form-control" data-foo="bar" value="value" />'
Actual
+' <input type="text" id="text" name="text" disabled="disabled" required="required" readonly="readonly" maxlength="10" pattern="\d+" class="foobar form-control" data-foo="bar" value="value" />'
src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_4_layout.html.twig
Show resolved
Hide resolved
|
@Oviglo maybe you need follow the instructions to rebase your code according to https://symfony.com/doc/current/contributing/code/pull_requests.html#step-4-submit-your-pull-request and pass the fabbot.io check |
Add 'form-control-range' for range input type.
Apudate bootstrap range test
Add 'form-control-range' for range input type.