[Bridge\Twig] Add 'form-control-range' for range input type #40472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngelFQC
reviewed
Mar 16, 2021
There was a problem hiding this comment.
Hi @Oviglo
Me, again :)
In this pull request you are mixing minor changes (like format of code) and logical changes
From the documentation, here https://symfony.com/doc/current/contributing/code/pull_requests.html#work-on-your-pull-request
There are three points to consider:
- Do atomic and logically separate commits (use the power of git rebase to have a clean and logical history);
- Never fix coding standards in some existing code as it makes the code review more difficult;
- Write good commit messages: Start by a short subject line (the first line), followed by a blank line and a more detailed
nicolas-grekas
approved these changes
Mar 16, 2021
src/Symfony/Bridge/Twig/Tests/Extension/AbstractBootstrap4LayoutTest.php
Outdated
Show resolved
Hide resolved
|
Thank you @Oviglo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'form-control-range' for range input type for Bootstrap theme, see the doc