8000 [TwigBridge] Update bootstrap_4_layout.html.twig by Oviglo · Pull Request #38625 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[TwigBridge] Update bootstrap_4_layout.html.twig #38625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[TwigBridge] Update bootstrap_4_layout.html.twig #38625

wants to merge 1 commit into from

Conversation

Oviglo
Copy link
Contributor
@Oviglo Oviglo commented Oct 19, 2020 •
edited by nicolas-grekas
Loading
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Add 'form-control-range' for range input type.

@Oviglo
Update bootstrap_4_layout.html.twig
f9f7b74 
Add 'form-control-range' for range input type.
@nicolas-grekas nicolas-grekas changed the title Update bootstrap_4_layout.html.twig [TwigBridge] Update bootstrap_4_layout.html.twig Oct 19, 2020
@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Oct 19, 2020
@nicolas-grekas
Copy link
Member

(for 4.4)
Can you please have a look at failing tests?

@Oviglo
Copy link
Contributor Author
Oviglo commented Oct 19, 2020

(for 4.4)
Can you please have a look at failing tests?

Yes, the test check if class name contains "form-control" but in Bootstrap doc the range input type need to have "form-control-range" : https://getbootstrap.com/docs/4.5/components/forms/#range-inputs

@nicolas-grekas
Copy link
Member

Yes, the test check if class name contains "form-control" but in Bootstrap doc the range input type need to have "form-control-range"

Sure, can you fix the tests please?

Nyholm
Nyholm requested changes Oct 19, 2020
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey.

Have a look how the current custom forms are implemented. (see the docs: https://symfony.com/doc/current/form/bootstrap4.html#custom-forms)

We should implement this in the same way.

@fabpot
Copy link
Member
fabpot commented Nov 17, 2020

@Oviglo Are you still interested in finishing this PR?

@nicolas-grekas
Copy link
Member

Closing as this staled.
@Oviglo please submit when you can!

@Oviglo Oviglo mentioned this pull request Mar 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm requested changes

Assignees
No one assigned
Labels
Bug Status: Needs Work TwigBridge
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@Oviglo @nicolas-grekas @fabpot @Nyholm @xabbuh @carsonbot
0