8000 Use class const in test by OskarStark · Pull Request #39931 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Use class const in test #39931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2021
Merged

Use class const in test #39931

merged 1 commit into from
Jan 22, 2021

Conversation

OskarStark
Copy link
Contributor
@OskarStark OskarStark commented Jan 22, 2021 •
edited
Loading
Q A
Branch? 5.1
Bug fix? no
New feature? no
Deprecations? no
Tickets ---
License MIT
Doc PR ---

super minor, same as #39930, but for 5.1

I will finish this PR after #39930 is merged and upmerged

@carsonbot carsonbot added this to the 5.1 milestone Jan 22, 2021
@carsonbot carsonbot changed the title [Security] [HttpFoundation] Use class const in test [HttpFoundation][Security] Use class const in test Jan 22, 2021
jderusse
jderusse reviewed Jan 22, 2021
View reviewed changes
Copy link
Member
@jderusse jderusse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 5.1 and not 4.4?
Remaining occurences in

  • Bundle/WebProfilerBundle/Tests/DependencyInjection/WebProfilerExtensionTest.php
  • Component/Console/Tests/Logger/ConsoleLoggerTest.php
  • Component/Security/Http/Tests/Firewall/AccessListenerTest.php

@OskarStark
Copy link
Contributor Author

4.4 is here: #39930

Will check the others, thanks

@OskarStark OskarStark changed the title [HttpFoundation][Security] Use class const in test Use class const in test Jan 22, 2021
@carsonbot carsonbot changed the title Use class const in test [HttpFoundation][Security] Use class const in test Jan 22, 2021
@OskarStark OskarStark changed the title [HttpFoundation][Security] Use class const in test Use class const in test Jan 22, 2021
@jderusse
Copy link
Member

Thank you @OskarStark.

@jderusse jderusse merged commit 2645226 into symfony:5.1 Jan 22, 2021
@OskarStark OskarStark deleted the use-class-const-5.1 branch January 22, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jderusse jderusse jderusse left review comments

@derrabus derrabus derrabus approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

Assignees
No one assigned
Labels
HttpFoundation Security Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@OskarStark @jderusse @derrabus @carsonbot
0