minor #39931 Use class const in test (OskarStark)

jderusse · jderusse · commit 26452260ed73 · 2021-01-22T11:24:07.000+01:00
This PR was merged into the 5.1 branch. Discussion ---------- Use class const in test | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- super minor, same as #39930, but for `5.1` I will finish this PR after #39930 is merged and upmerged Commits ------- 4a98eee [Security] [HttpFoundation] Use class const in test
diff --git a/src/Symfony/Component/Security/Http/Tests/Authenticator/FormLoginAuthenticatorTest.php b/src/Symfony/Component/Security/Http/Tests/Authenticator/FormLoginAuthenticatorTest.php
@@ -13,6 +13,7 @@
 
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Session\SessionInterface;
 use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 use Symfony\Component\Security\Core\Exception\BadCredentialsException;
 use Symfony\Component\Security\Core\Security;
@@ -165,7 +166,7 @@ private function setUpAuthenticator(array $options = [])
 
     private function createSession()
     {
-        return $this->createMock('Symfony\Component\HttpFoundation\Session\SessionInterface');
+        return $this->createMock(SessionInterface::class);
     }
 }
 
diff --git a/src/Symfony/Component/Security/Http/Tests/Firewall/LogoutListenerTest.php b/src/Symfony/Component/Security/Http/Tests/Firewall/LogoutListenerTest.php
@@ -19,6 +19,7 @@
 use Symfony\Component\HttpKernel\Event\RequestEvent;
 use Symfony\Component\Security\Http\Event\LogoutEvent;
 use Symfony\Component\Security\Http\Firewall\LogoutListener;
+use Symfony\Component\Security\Http\Logout\LogoutHandlerInterface;
 use Symfony\Component\Security\Http\Logout\LogoutSuccessHandlerInterface;
 
 class LogoutListenerTest extends TestCase
@@ -183,7 +184,7 @@ public function testLegacyLogoutHandlers()
         $response = new Response();
         $logoutSuccessHandler->expects($this->any())->method('onLogoutSuccess')->willReturn($response);
 
-        $handler = $this->createMock('Symfony\Component\Security\Http\Logout\LogoutHandlerInterface');
+        $handler = $this->createMock(LogoutHandlerInterface::class);
         $handler->expects($this->once())->method('logout')->with($request, $response, $token);
         $listener->addHandler($handler);
 

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@`
`13`	`13`
`14`	`14`	`use PHPUnit\Framework\TestCase;`
`15`	`15`	`use Symfony\Component\HttpFoundation\Request;`
	`16`	`+use Symfony\Component\HttpFoundation\Session\SessionInterface;`
`16`	`17`	`use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;`
`17`	`18`	`use Symfony\Component\Security\Core\Exception\BadCredentialsException;`
`18`	`19`	`use Symfony\Component\Security\Core\Security;`
`@@ -165,7 +166,7 @@ private function setUpAuthenticator(array $options = [])`
`165`	`166`
`166`	`167`	`private function createSession()`
`167`	`168`	`{`
`168`		`- return $this->createMock('Symfony\Component\HttpFoundation\Session\SessionInterface');`
	`169`	`+ return $this->createMock(SessionInterface::class);`
`169`	`170`	`}`
`170`	`171`	`}`
`171`	`172`