Use class const in test #39930

OskarStark · 2021-01-22T07:05:05Z

Q	A
Branch?	4.4
Bug fix?	no
New feature?	no
Deprecations?	no
Tickets	---
License	MIT
Doc PR	---

super minor

jderusse · 2021-01-22T10:22:04Z

Thank you @OskarStark.

This PR was merged into the 5.1 branch. Discussion ---------- Use class const in test | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | --- | License | MIT | Doc PR | --- super minor, same as #39930, but for `5.1` I will finish this PR after #39930 is merged and upmerged Commits ------- 4a98eee [Security] [HttpFoundation] Use class const in test

OskarStark requested review from chalasr and wouterj as code owners January 22, 2021 07:05

carsonbot added Status: Needs Review Security labels Jan 22, 2021

carsonbot added this to the 4.4 milestone Jan 22, 2021

OskarStark mentioned this pull request Jan 22, 2021

Use class const in test #39931

Merged

Use class const in test

39181f4

OskarStark force-pushed the use-class-const-4.4 branch from eaede17 to 39181f4 Compare January 22, 2021 07:46

OskarStark changed the title ~~[Security] Use class const in test~~ Use class const in test Jan 22, 2021

OskarStark removed the Security label Jan 22, 2021

derrabus approved these changes Jan 22, 2021

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Jan 22, 2021

jderusse merged commit 10f3b10 into symfony:4.4 Jan 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use class const in test #39930

Use class const in test #39930

Use class const in test #39930

Use class const in test #39930

Conversation