8000 Basque translations by ikerib · Pull Request #39359 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Basque translations #39359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2020
Merged

Basque translations #39359

merged 1 commit into from
Dec 17, 2020

Conversation

ikerib
Copy link
Contributor
@ikerib ikerib commented Dec 7, 2020

Fix #38726

Nyholm
Nyholm reviewed Dec 7, 2020
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. You are the best!

I used Google Translate to try to review/confirm this. I have two comments, I might be very wrong but can you double check?

I also see that you accidentally included some other commits and targeted 5.x instead of 4.4, but is okey. You dont have to fix that. The person that merges the PR will fix with that later. Just answer my two questions below and I'll be super happy.

@Nyholm
Copy link
Member
Nyholm commented Dec 7, 2020

@cluster28 if you have time and are able to, could you please review this?

@jderusse jderusse added this to the 4.4 milestone Dec 8, 2020
@cluster28
Copy link
Contributor

@olatzromeo could you check that form me? Thnak you.

@fabpot fabpot changed the base branch from 5.x to 4.4 December 17, 2020 16:47
@fabpot
Copy link
Member
fabpot commented Dec 17, 2020

Thank you @ikerib.

@fabpot fabpot merged commit def8181 into symfony:4.4 Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm left review comments

@fabpot fabpot fabpot approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

@dunglas dunglas Awaiting requested review from dunglas

@jderusse jderusse Awaiting requested review from jderusse

@lyrixx lyrixx Awaiting requested review from lyrixx

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Missing translations Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Missing translations for Basque (eu)
6 participants
@ikerib @Nyholm @cluster28 @fabpot @jderusse @carsonbot
0