8000 [RateLimiter] Fix delete method of the cache storage by GregOriol · Pull Request #38661 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[RateLimiter] Fix delete method of the cache storage #38661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2020
Merged

[RateLimiter] Fix delete method of the cache storage #38661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb540bb
Fix delete method on RateLimiter's cache storage
GregOriol Oct 21, 2020
88c1e24
Added a test
Nyholm Oct 22, 2020
b61d9d1
minor
Nyholm Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/RateLimiter/Storage/CacheStorage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,6 @@ public function fetch(string $limiterStateId): ?LimiterStateInterface

public function delete(string $limiterStateId): void
{
$this->pool->deleteItem($limiterStateId);
$this->pool->deleteItem(sha1($limiterStateId));
}
}
7 changes: 7 additions & 0 deletions src/Symfony/Component/RateLimiter/Tests/Storage/CacheStorageTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,4 +76,11 @@ public function testFetchNonExistingState()

$this->assertNull($this->storage->fetch('test'));
}

public function testDelete()
{
$this->pool->expects($this->once())->method('deleteItem')->with(sha1('test'))->willReturn(true);
Copy link
Member
@Nyholm Nyholm Oct 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line uses $this->pool which is a mock created in setUp().

We say that we "expect" that "once" the "method deleteItem" is called with sha1('test'). We also return true.

If what we expect does not happen, then the test will fail


$this->storage->delete('test');
Copy link
Member
@Nyholm Nyholm Oct 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just calling the storage

}
}
0