[RateLimiter] Fix delete method of the cache storage #38661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
approved these changes
Oct 21, 2020
|
I'm not sure how to write such a test, I'd rather not try to make something up here. |
|
Do you mind if I push to your branch? |
|
Not at all, I'd be happy to take your suggestion on this :-) |
Nyholm
approved these changes
Oct 22, 2020
|
|
||
| public function testDelete() | ||
| { | ||
| $this->pool->expects($this->once())->method('deleteItem')->with(sha1('test'))->willReturn(true); |
There was a problem hiding this comment.
This line uses $this->pool which is a mock created in setUp().
We say that we "expect" that "once" the "method deleteItem" is called with sha1('test'). We also return true.
If what we expect does not happen, then the test will fail
| { | ||
| $this->pool->expects($this->once())->method('deleteItem')->with(sha1('test'))->willReturn(true); | ||
|
|
||
| $this->storage->delete('test'); |
There was a problem hiding this comment.
This is just calling the storage
jderusse
approved these changes
Oct 22, 2020
|
Thank you @GregOriol. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small issue with RateLimiter's cache storage and the delete method: all getItems are called with a sha1 of the id, but not the one for delete, which makes it miss the deletion.