8000 [RateLimiter] Fix delete method of the cache storage by GregOriol · Pull Request #38661 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[RateLimiter] Fix delete method of the cache storage #38661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2020
Merged

[RateLimiter] Fix delete method of the cache storage #38661

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb540bb
Fix delete method on RateLimiter's cache storage
GregOriol Oct 21, 2020
88c1e24
Added a test
Nyholm Oct 22, 2020
b61d9d1
minor
Nyholm Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix delete method on RateLimiter's cache storage
  • Loading branch information
@GregOriol
GregOriol committed Oct 22, 2020
commit fb540bba73d4d4d2d3fecac77a488b27eedabf6c
2 changes: 1 addition & 1 deletion src/Symfony/Component/RateLimiter/Storage/CacheStorage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,6 @@ public function fetch(string $limiterStateId): ?LimiterStateInterface

public function delete(string $limiterStateId): void
{
$this->pool->deleteItem($limiterStateId);
$this->pool->deleteItem(sha1($limiterStateId));
}
}
0