[Console] Table: support cells with newlines after a cell with colspan >= 2 #37731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c755f9 to
4776950
Compare
724457a to
960aee9
Compare
fabpot
approved these changes
Aug 11, 2020
|
Thank you @gmta. |
960aee9 to
ca11772
Compare
gmta
pushed a commit
to gmta/symfony
that referenced
this pull request
Aug 11, 2020
These changes were introduced in symfony#37731 but no longer contributed to the actual fix, which was to perform a ->copyRow().
fabpot
added a commit
that referenced
this pull request
Aug 12, 2020
This PR was merged into the 4.4 branch. Discussion ---------- [Console] Revert changes to Table->fillCells() | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A These changes were introduced in #37731 but no longer contributed to the actual fix, which was to perform a ->copyRow(). Commits ------- 17263ca Revert changes to Table->fillCells()
symfony-splitter
pushed a commit
to symfony/console
that referenced
this pull request
Aug 12, 2020
These changes were introduced in symfony/symfony#37731 but no longer contributed to the actual fix, which was to perform a ->copyRow().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering a table with a cell containing newlines after a cell with
colspan set to at least 2, every line in the cell with newlines except the
first one fails to render.
This case is fixed by calling
->fillCells()on the unmerged rows andimplementing support for rows that start with a non-zero index for the columns.
While fixing this, I discovered another issue with colspan: if a cell following a
colspanned cell contains enough newlines to make the contents extend further
than the colspanned cell's contents, the cells become misaligned. This is now
also fixed.