8000 [Console] Revert changes to Table->fillCells() by gmta · Pull Request #37804 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Revert changes to Table->fillCells() #37804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2020
Merged

[Console] Revert changes to Table->fillCells() #37804

merged 1 commit into from
Aug 12, 2020

Conversation

gmta
Copy link
@gmta gmta commented Aug 11, 2020 •
edited
Loading
Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

These changes were introduced in #37731 but no longer contributed to the actual fix, which was to perform a ->copyRow().

Revert changes to Table->fillCells()
17263ca 
These changes were introduced in symfony#37731
but no longer contributed to the actual fix, which was to perform a
->copyRow().
@gmta gmta changed the title Revert changes to Table->fillCells() [Console] Revert changes to Table->fillCells() Aug 11, 2020
@fabpot
Copy link
Member
fabpot commented Aug 12, 2020

Thank you for the followup @gmta

@fabpot fabpot merged commit 8761f80 into symfony:4.4 Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmta @fabpot @carsonbot
0