Revert changes to Table->fillCells()

Jelle Raaijmakers · Jelle Raaijmakers · commit 17263ca14dec · 2020-08-11T19:02:45.000+02:00
These changes were introduced in #37731 but no longer contributed to the actual fix, which was to perform a ->copyRow().
diff --git a/src/Symfony/Component/Console/Helper/Table.php b/src/Symfony/Component/Console/Helper/Table.php
@@ -674,16 +674,12 @@ private function fillCells($row)
     {
         $newRow = [];
 
-        $newColumn = null;
         foreach ($row as $column => $cell) {
-            if (null === $newColumn) {
-                $newColumn = $column;
-            }
-            $newRow[$newColumn++] = $cell;
+            $newRow[] = $cell;
             if ($cell instanceof TableCell && $cell->getColspan() > 1) {
                 foreach (range($column + 1, $column + $cell->getColspan() - 1) as $position) {
                     // insert empty value at column position
-                    $newRow[$newColumn++] = '';
+                    $newRow[] = '';
                 }
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -674,16 +674,12 @@ private function fillCells($row)`
`674`	`674`	`{`
`675`	`675`	`$newRow = [];`
`676`	`676`
`677`		`- $newColumn = null;`
`678`	`677`	`foreach ($row as $column => $cell) {`
`679`		`- if (null === $newColumn) {`
`680`		`- $newColumn = $column;`
`681`		`- }`
`682`		`- $newRow[$newColumn++] = $cell;`
	`678`	`+ $newRow[] = $cell;`
`683`	`679`	`if ($cell instanceof TableCell && $cell->getColspan() > 1) {`
`684`	`680`	`foreach (range($column + 1, $column + $cell->getColspan() - 1) as $position) {`
`685`	`681`	`// insert empty value at column position`
`686`		`- $newRow[$newColumn++] = '';`
	`682`	`+ $newRow[] = '';`
`687`	`683`	`}`
`688`	`684`	`}`
`689`	`685`	`}`