[Fragment] Move configuration to PHP #37211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | Ref #37186 |
| License | MIT |
javiereguiluz
approved these changes
Jun 11, 2020
There was a problem hiding this comment.
This looks correct to me!
I only have two minor questions:
(1) Should we standardize the order of PHP calls? In the original XML file, the tag was added before the args, so in PHP is the same:
->tag('kernel.event_subscriber')
->args([
service('uri_signer'),
param('fragment.path'),
])But maybe we should put args first always?
->args([
service('uri_signer'),
param('fragment.path'),
])
->tag('kernel.event_subscriber')(2) We should probably inline some args() calls because their service list is short enough:
// Before
->args([
service('uri_signer'),
param('fragment.path'),
])
// After
->args([service('uri_signer'), param('fragment.path')])
massamba00
approved these changes
Jun 11, 2020
|
tags are added after the args (and calls) in the other PRs. So I think this should be changed for consistency here. |
|
@Tobion , so order is ->args()
->call()
->tag()Right ? |
Tobion
approved these changes
Jun 11, 2020
yceruto
approved these changes
Jun 11, 2020
|
If someone can help, i don't know how to fix the test 😢 |
|
@idetox don't worry about it, it's a random failure. I've re-run the jobs to see if it happens now. |
fabpot
approved these changes
Jun 11, 2020
|
Can you squash your commits please? |
|
Thank you @idetox. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.