8000 [FrameworkBundle] Move debug configuration to PHP by TuxBoy · Pull Request #37212 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Move debug configuration to PHP #37212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2020
Merged

[FrameworkBundle] Move debug configuration to PHP #37212

merged 1 commit into from
Jun 11, 2020

Conversation

TuxBoy
Copy link
@TuxBoy TuxBoy commented Jun 11, 2020
Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets Ref #37186
License MIT

@nicolas-grekas nicolas-grekas added this to the next milestone Jun 11, 2020
yceruto
yceruto reviewed Jun 11, 2020
View reviewed changes
yceruto
yceruto reviewed Jun 11, 2020
View reviewed changes
yceruto
yceruto reviewed Jun 11, 2020
View reviewed changes
yceruto
yceruto reviewed Jun 11, 2020
View reviewed changes
@yceruto
Copy link
Member
yceruto commented Jun 11, 2020 •
edited
Loading

please check the fabbot report, there are other CS issues to solve:
https://fabbot.io/report/symfony/symfony/37212/d75bd684374658538d9f017173d1fa1ef3b9b6bc

yceruto
yceruto approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member
@yceruto yceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fabpot
Copy link
Member
fabpot commented Jun 11, 2020

Thank you @TuxBoy.

@fabpot fabpot merged commit 188a985 into symfony:master Jun 11, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
5.2
< 3E19 div class="discussion-sidebar-heading text-bold"> Development

Successfully merging this pull request may close these issues.

5 participants
@TuxBoy @yceruto @fabpot @nicolas-grekas @carsonbot
0