8000 Pass exceptions from the ExceptionListener to Monolog by mpdude · Pull Request #8000 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
/ symfony Public < 8000 /div>

Pass exceptions from the ExceptionListener to Monolog #8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Pass exceptions from the ExceptionListener to Monolog #8000

wants to merge 2 commits into from

Conversation

mpdude
Copy link
Contributor
@mpdude mpdude commented May 10, 2013
Q A
Bug fix? rather yes
New feature? rather no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #7973, #7976
License MIT
Doc PR n/a

Pass exceptions caught by the ExceptionListener to Monolog, using the log message context. As of Monolog 1.5, exceptions passed that way will at least be logged with the line they were thrown in, also including any previous exceptions.

Getting full stack traces (as suggested in #7976) becomes a possible change at the Monolog level (see Seldaek/monolog#192) or users can add their own Monolog Formatter for that.

This PR is based on master. I'd be glad to provide similar ones for 2.1/2.2 if you'd pick them. Due to recent changes in the ExceptionListener I don't think a single patch on the older branches can easily be pulled to master anyway.

@fabpot fabpot closed this in 31138f4 May 10, 2013
@mpdude mpdude deleted the pass-excpetions-to-monolog branch May 10, 2013 09:50
@mpdude
Copy link
Contributor Author
mpdude commented May 10, 2013

@fabpot Thanks and congrats on 8000 PRs :-)!

@mpdude mpdude mentioned this pull request May 10, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mpdude
0