8000 [HttpFoundation] Fixed Mime dependency missing error by HeahDude · Pull Request #35808 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] Fixed Mime dependency missing error #35808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2020
Merged

[HttpFoundation] Fixed Mime dependency missing error #35808

merged 1 commit into from
Feb 23, 2020

Conversation

HeahDude
Copy link
Contributor
Q A
Branch? master
Bug fix? kinda
New feature? no
Deprecations? no
Tickets ~
License MIT
Doc PR ~

Follows #35642, by adding a missing exception and a note in the UPGRADE file (CHANGELOG in HttpFoundation was already up to date).
Reported in symfony/symfony-docs#1307

@HeahDude HeahDude mentioned this pull request Feb 20, 2020
Closed
@GrahamCampbell
Copy link
Contributor

I already submitted a fix for this 30 minutes before this PR at #35807.

@GrahamCampbell
Copy link
Contributor

I would still argue for reverting all this entirely for the reasons explained on my PR.

@nicolas-grekas nicolas-grekas mentioned this pull request Feb 23, 2020
Closed
@nicolas-grekas nicolas-grekas added this to the next milestone Feb 23, 2020
@nicolas-grekas
Copy link
Member

Thank you @HeahDude.

@nicolas-grekas nicolas-grekas merged commit b3b368b into symfony:master Feb 23, 2020
@HeahDude HeahDude deleted the fix-mimes-dep-error branch February 23, 2020 10:41
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@GrahamCampbell GrahamCampbell GrahamCampbell approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
HttpFoundation Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@HeahDude @GrahamCampbell @nicolas-grekas @chalasr @carsonbot
0