8000 Links labels to previous and next chapters are double escaped · Issue #1307 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Links labels to previous and next chapters are double escaped #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hhamon opened this issue Apr 25, 2012 · 2 comments
Closed

Links labels to previous and next chapters are double escaped #1307

hhamon opened this issue Apr 25, 2012 · 2 comments

Comments

@hhamon
Copy link
Contributor
hhamon commented Apr 25, 2012

In the Propel chapter of the book, the links labels at the bottom of the chapter that point to the previous and next chapters are double espaced. We have this output:

« Databases and Doctrine ("The Model") | Testing »

Instead of this:

« Databases and Doctrine (« The Model ») | Testing »
@willdurand
Copy link
Contributor

I also noticed that

@weaverryan
Copy link
Member

Hey guys!

I've removed "The Model" from both articles. This was back when I felt it important to help guide the user to where they could find each of the MVC parts. But, I think that calling the database layer the model isn't really useful and, of course, isn't totally accurate anyways.

So, this doesn't really address the escaping issue, but I think it's the best and easiest.

Thoughts?

weaverryan added a commit that referenced this issue Apr 29, 2012
@weaverryan
Removing "The Model". It was causing escaping problems, and I don't t…
cbe13fd 
…hink it's really necessary to point out that this is the model (when technically it really isn't completely the model).

See #1264 and #1307
This was referenced Jun 27, 2012
Closed
Closed
@HeahDude HeahDude mentioned this issue Feb 20, 2020
Merged
nicolas-grekas added a commit to symfony/symfony that referenced this issue Feb 23, 2020
@nicolas-grekas
minor #35808 [HttpFoundation] Fixed Mime dependency missing error (He…
b3b368b 
…ahDude)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[HttpFoundation] Fixed Mime dependency missing error

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | kinda
| New feature?  | no
| Deprecations? | no
| Tickets       | ~
| License       | MIT
| Doc PR        | ~

Follows #35642, by adding a missing exception and a note in the UPGRADE file (CHANGELOG in HttpFoundation was already up to date).
Reported in symfony/symfony-docs#1307

Commits
-------

fef0de3 [HttpFoundation] Fixed Mimes dependency missing error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@weaverryan @willdurand @hhamon
0