minor #35808 [HttpFoundation] Fixed Mime dependency missing error (HeahDude)

nicolas-grekas · nicolas-grekas · commit b3b368b80033 · 2020-02-23T10:28:35.000+01:00
This PR was merged into the 5.1-dev branch. Discussion ---------- [HttpFoundation] Fixed Mime dependency missing error | Q | A | ------------- | --- | Branch? | master | Bug fix? | kinda | New feature? | no | Deprecations? | no | Tickets | ~ | License | MIT | Doc PR | ~ Follows #35642, by adding a missing exception and a note in the UPGRADE file (CHANGELOG in HttpFoundation was already up to date). Reported in symfony/symfony-docs#1307 Commits ------- fef0de3 [HttpFoundation] Fixed Mimes dependency missing error
diff --git a/UPGRADE-5.1.md b/UPGRADE-5.1.md
@@ -36,6 +36,7 @@ HttpFoundation
  * Deprecate `Response::create()`, `JsonResponse::create()`,
    `RedirectResponse::create()`, and `StreamedResponse::create()` methods (use
    `__construct()` instead)
+ * Made the Mime component an optional dependency
 
 Messenger
 ---------
diff --git a/src/Symfony/Component/HttpFoundation/File/File.php b/src/Symfony/Component/HttpFoundation/File/File.php
@@ -74,6 +74,10 @@ public function guessExtension()
      */
     public function getMimeType()
     {
+        if (!class_exists(MimeTypes::class)) {
+            throw new \LogicException('You cannot guess the mime type as the Mime component is not installed. Try running "composer require symfony/mime".');
+        }
+
         return MimeTypes::getDefault()->guessMimeType($this->getPathname());
     }
 

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,10 @@ public function guessExtension()`
`74`	`74`	`*/`
`75`	`75`	`public function getMimeType()`
`76`	`76`	`{`
	`77`	`+ if (!class_exists(MimeTypes::class)) {`
	`78`	`+ throw new \LogicException('You cannot guess the mime type as the Mime component is not installed. Try running "composer require symfony/mime".');`
	`79`	`+ }`
	`80`	`+`
`77`	`81`	`return MimeTypes::getDefault()->guessMimeType($this->getPathname());`
`78`	`82`	`}`
`79`	`83`