8000 [Validator] Add the missing translations for the Hebrew ("he") locale and fix 2 typos by Tamarpe · Pull Request #34135 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Add the missing translations for the Hebrew ("he") locale and fix 2 typos #34135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2019
Merged

[Validator] Add the missing translations for the Hebrew ("he") locale and fix 2 typos #34135

merged 1 commit into from
Nov 5, 2019

Conversation

Tamarpe
Copy link
Contributor
@Tamarpe Tamarpe commented Oct 26, 2019
Q A
Branch? 3.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #30166
License MIT

Ref #30166

@fabpot
Copy link
Member
fabpot commented Oct 27, 2019

Thank you for your contribution. Can you also add the translations for ids between 79 and 94?

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Oct 27, 2019
@nicolas-grekas nicolas-grekas changed the title [Validator] Add the missing translations for the Hebrew ("he") locale… [Validator] Add the missing translations for the Hebrew ("he") locale and fix 2 typos Oct 27, 2019
@Tamarpe
Copy link
Contributor Author
Tamarpe commented Oct 27, 2019

Thank you for your contribution. Can you also add the translations for ids between 79 and 94?

Done! the pull request is updated.

nicolas-grekas
nicolas-grekas approved these changes Nov 5, 2019
View reviewed changes
@Tamarpe Tamarpe force-pushed the add-missing-he-validator-translation-file branch from c633e54 to eb3507d Compare November 5, 2019 21:28
@Tamarpe
Copy link
Contributor Author
Tamarpe commented Nov 5, 2019

Fixed- a104eab

@fabpot fabpot force-pushed the add-missing-he-validator-translation-file branch from a104eab to 022cf67 Compare November 5, 2019 22:03
@fabpot
Copy link
Member
fabpot commented Nov 5, 2019

Thank you @Tamarpe.

fabpot added a commit that referenced this pull request Nov 5, 2019
@fabpot
minor #34135 [Validator] Add the missing translations for the Hebrew …
9151698 
…("he") locale and fix 2 typos (Tamarpe)

This PR was squashed before being merged into the 3.4 branch (closes #34135).

Discussion
----------

[Validator] Add the missing translations for the Hebrew ("he") locale and fix 2 typos

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #30166
| License       | MIT

Ref #30166

Commits
-------

022cf67 [Validator] Add the missing translations for the Hebrew (\"he\") locale and fix 2 typos
@fabpot fabpot merged commit 022cf67 into symfony:3.4 Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed Validator
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Tamarpe @fabpot @nicolas-grekas @carsonbot
0