8000 [MonologBridge] Add Mailer handler by BoShurik · Pull Request #33456 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[MonologBridge] Add Mailer handler #33456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2020
Merged

[MonologBridge] Add Mailer handler #33456

merged 1 commit into from
Feb 8, 2020

Conversation

BoShurik
Copy link
Contributor
@BoShurik BoShurik commented Sep 4, 2019 •
edited
Loading
Q A
Branch? 4.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #33209
License MIT
Doc PR -

stof
stof requested changes Sep 4, 2019
View reviewed changes
Copy link
Member
@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are missing

@BoShurik
Copy link
Contributor Author
BoShurik commented Sep 4, 2019

@stof done, but not sure why build fails. Looks like unrelated

@nicolas-grekas nicolas-grekas added this to the next milestone Sep 6, 2019
@weaverryan weaverryan modified the milestones: next, 4.4 Oct 28, 2019
@weaverryan
Copy link
Member

Proposing this for the 4.4 milestone so that this doesn't block Mailer as a first-class citizen in 4.4/5.0

@nicolas-grekas nicolas-grekas changed the title Add monolog mailer handler [MonologBridge] Add Mailer handler Nov 5, 2019
@weaverryan weaverryan modified the milestones: 4.4, next Dec 2, 2019
@acasademont
Copy link
Contributor

Any news here? I guess a PR to monolog-bundle would be also needed?

@BoShurik BoShurik requested review from stof and fabpot December 12, 2019 10:57
@BoShurik BoShurik requested a review from weaverryan December 12, 2019 10:58
@javiereguiluz javiereguiluz mentioned this pull request Dec 16, 2019
Merged
OskarStark added a commit to symfony/symfony-docs that referenced this pull request Dec 17, 2019
@OskarStark
minor #12818 [Monolog] Add a caution note about Symfony Mailer and Mo…
eef9be6 
…nolog (javiereguiluz)

This PR was merged into the 4.3 branch.

Discussion
----------

[Monolog] Add a caution note about Symfony Mailer and Monolog

We can't fix #12758 properly until this is fixed in symfony/symfony#33456  but meanwhile we can display a caution message to avoid confusion.

Commits
-------

82119af [Monolog] Add a caution note about Symfony Mailer and Monolog
@a-menshchikov a-menshchikov mentioned this pull request Dec 17, 2019
Open
@mmarton
Copy link
mmarton commented Jan 6, 2020

Any update here? It's the last reason we are still on swiftmailer. :/

@noniagriconomie
Copy link
Contributor

Hi @BoShurik, how can I help to get this for 5.1?

Thank you,

@BoShurik
Copy link
Contributor Author

@noniagriconomie Hi! Sorry for delay. I'll add changes by the end of the week

@BoShurik BoShurik requested review from sroze and xabbuh as code owners January 16, 2020 20:56
@BoShurik BoShurik changed the base branch from 4.4 to master January 16, 2020 21:05
@BoShurik
Copy link
Contributor Author

Needs a review

@fabp 8000 ot
Copy link
Member
fabpot commented Feb 8, 2020

Thank you @BoShurik.

@fabpot fabpot mentioned this pull request Feb 8, 2020
Closed
fabpot added a commit that referenced this pull request Feb 8, 2020
@fabpot
feature #33456 [MonologBridge] Add Mailer handler (BoShurik)
916ff10 
This PR was merged into the 5.1-dev branch.

Discussion
----------

[MonologBridge] Add Mailer handler

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #33209   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | - <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

5b7393b Add monolog mailer handler
@fabpot fabpot merged commit 5b7393b into symfony:master Feb 8, 2020
@noniagriconomie noniagriconomie mentioned this pull request Feb 12, 2020
Closed
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
@acasademont acasademont mentioned this pull request Jun 5, 2020
Merged
@Schyzophrenic
Copy link

As many others, this is the last reason we use SwiftMailer. Is there any chance this will be merged into SF 4.4?

@fabpot
Copy link
Member
fabpot commented Jun 12, 2020

@Schyzophrenic No, new features are never backported.

lyrixx added a commit to symfony/monolog-bundle that referenced this pull request Oct 2, 2020
@lyrixx
feature #354 Add Symfony Mailer support (acasademont)
24f27fb 
This PR was squashed before being merged into the 3.x-dev branch.

Discussion
----------

Add Symfony Mailer support

Add support for the new symfony mailer directly on the bundle after the MailerHandle was added to the bridge on symfony/symfony#33456

Also this can make symfony/symfony-docs#13077 move forward

Tests are failing due to incompatible phpunit versions, not sure how to fix this...

Commits
-------

4bea89c Add Symfony Mailer support
@noniagriconomie noniagriconomie mentioned this pull request Oct 6, 2020
Merged
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Oct 7, 2020
@javiereguiluz
minor symfony#14360 Document usage of Symfony Mailer for error email …
1cf3cd6 
…(noniagriconomie, OskarStark)

This PR was merged into the 5.1 branch.

Discussion
----------

Document usage of Symfony Mailer for error email

Related to symfony/monolog-bundle#354
and symfony/monolog-bundle#354 (comment)

----------

Should we also document that for the `v4.4` of this page, it will not be possible?
The `Symfony\Bridge\Monolog\Handler\MailerHandler` was added in `v5.1` (symfony/symfony#33456)

Because the wording `compatible yet` implies that it will be compatible in the future

Thank you

edit: I do not understand the `DOCtor-RST` check here :s

Commits
-------

202b9e6 Update message
d20f07c Fix: DOXtor-RST
922932f Makes DOCtor-RST happy
3df4d9e Document usage of Symfony Mailer for error email
@faizanakram99
Copy link
Contributor

How to use MailerHandler without framework ?

dani-danigm pushed a commit to dani-danigm/monolog-bundle that referenced this pull request Jun 15, 2022
@lyrixx
feature #354 Add Symfony Mailer support (acasademont)
66b7ac8 
This PR was squashed before being merged into the 3.x-dev branch.

Discussion
----------

Add Symfony Mailer support

Add support for the new symfony mailer directly on the bundle after the MailerHandle was added to the bridge on symfony/symfony#33456

Also this can make symfony/symfony-docs#13077 move forward

Tests are failing due to incompatible phpunit versions, not sure how to fix this...

Commits
-------

0b832f2 Add Symfony Mailer support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noniagriconomie noniagriconomie noniagriconomie left review comments

@fabpot fabpot fabpot approved these changes

@stof stof Awaiting requested review from stof

@weaverryan weaverryan Awaiting requested review from weaverryan

Assignees
No one assigned
Labels
Feature Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
0