8000 Document usage of Symfony Mailer for error email by noniagriconomie · Pull Request #14360 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Document usage of Symfony Mailer for error email #14360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 7, 2020
Merged

Document usage of Symfony Mailer for error email #14360

merged 4 commits into from
Oct 7, 2020

Conversation

noniagriconomie
Copy link
Contributor
@noniagriconomie noniagriconomie commented Oct 6, 2020 •
edited
Loading

Related to symfony/monolog-bundle#354
and symfony/monolog-bundle#354 (comment)

Should we also document that for the v4.4 of this page, it will not be possible?
The Symfony\Bridge\Monolog\Handler\MailerHandler was added in v5.1 (symfony/symfony#33456)

Because the wording compatible yet implies that it will be compatible in the future

Thank you

edit: I do not understand the DOCtor-RST check here :s

@noniagriconomie
Makes DOCtor-RST happy
922932f 
Error: You are not allowed to use version "3.6.0". Only major version "5" is allowed.
Error: Please only provide ".. versionadded::" if the version is greater/equal "5.0"
OskarStark
OskarStark reviewed Oct 6, 2020
View reviewed changes
@noniagriconomie
Copy link
Contributor Author

thx @OskarStark :)

just what do you think of the same sentence on the 4.4 code? should we alter the wording?

@javiereguiluz javiereguiluz added this to the 5.1 milestone Oct 7, 2020
@javiereguiluz javiereguiluz merged commit 1cf3cd6 into symfony:5.1 Oct 7, 2020
@javiereguiluz
Copy link
Member

Thanks Antoine! This is now merged in 5.1 and 5.x. You are right about tweaking the message in 4.4 version, so we did that in 70c96fb

@noniagriconomie noniagriconomie deleted the patch-11 branch October 7, 2020 12:32
@xabbuh xabbuh mentioned this pull request Jul 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@noniagriconomie @javiereguiluz @OskarStark @carsonbot
0