Update monolog_email.rst #13107
Closed
Update monolog_email.rst #13107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, I just add a link 😉
OskarStark
reviewed
Feb 12, 2020
| @@ -7,7 +7,7 @@ How to Configure Monolog to Email Errors | |||
| .. caution:: | |||
|
|
|||
| This feature is not compatible yet with the new :doc:`Symfony mailer </mailer>`, | |||
| so it requires using SwiftMailer. | |||
| so it requires using :doc:`SwiftMailer </email>`. | |||
There was a problem hiding this comment.
We at Symfony want the new Mailer is used, so adding a link and make it more simple to go to SwiftMailer does not makes sense to me.
There was a problem hiding this comment.
@OskarStark actually, monolog isn't compatible with Mailer. That's why i add the link 😉
There was a problem hiding this comment.
the PR has been merged recently
symfony/symfony#33456
so IMO ne more need to promote swiftmailer email logging
exept for older version maybe :)
|
Closing here for the given reasons. Thanks |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I just add a link 😉