8000 [Tests] Use proper phpunit assertion functions by stloyd · Pull Request #2909 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Tests] Use proper phpunit assertion functions #2909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Tests] Use proper phpunit assertion functions #2909

wants to merge 1 commit into from

Conversation

stloyd
Copy link
Contributor
@stloyd stloyd commented Dec 17, 2011 
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes

@stof
Copy link
Member
stof commented Dec 17, 2011

This will bump the requirement to PHPUnit 3.6 to run the testsuite so an update is probably needed somewhere in the doc

@stloyd
Copy link
Contributor Author
stloyd commented Dec 17, 2011

I was not sure about 2.0 but AFAIK master (#2910) requires PHPUnit 3.6 already. @fabpot ?

@stof
Copy link
Member
stof commented Dec 17, 2011

well, to be clear, requiring PHPUnit 3.6 is fine for me. We just need to check places where we refer to PHPUnit to update them

@fabpot
Copy link
Member
fabpot commented Dec 18, 2011

The doc specifies PHP 3.5 in two places: contributing/code/patches.rst and contributing/code/tests.rst. So, we should make these changes in 2.0. Doing it in master is fine, but you must also send a PR to update the requirements in the doc.

@stloyd stloyd mentioned this pull request Dec 18, 2011
Closed
@stloyd
Copy link
Contributor Author
stloyd commented Dec 18, 2011

@fabpot PR to docs sent. When you merge this one, I will rebase #2910.

@fabpot
Copy link
Member
fabpot commented Dec 19, 2011

@stloyd: sorry for the confusion but my comment said the opposite of what I had in mind. So let me say it again: These changes can NOT be made in the 2.0 branch as PHP 3.5 is explicitly mentioned in the docs. However, we can bump the PHPUnit requirement to 3.5, but ONLY for 2.1 (master branch). Can you rebase your doc PR to master? and rebase your 2 PRs here to master as well. Sorry for the confusion again.

@ghost
Copy link
ghost commented Dec 19, 2011

@fabpot

However, we can bump the PHPUnit requirement to 3.5, but ONLY for 2.1 (master branch).

I think you meant 3.6?

@fabpot
Copy link
Member
fabpot commented Dec 19, 2011

@Drak: correct

@stloyd stloyd closed this Dec 19, 2011
fabpot added a commit that referenced this pull request Aug 23, 2021
@fabpot
bug #42600 [HttpKernel] Fix timestamp_rfc3339 in LoggerDataCollector …
dabd127 
…(carlcasbolt)

This PR was merged into the 5.4 branch.

Discussion
----------

[HttpKernel] Fix timestamp_rfc3339 in LoggerDataCollector

Found that this was still needed for some log items to avoid an error in Profiler

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Ticket | Fixes #42622
| License       | MIT

Fix for the following error on Web Profiler when looking at error logs

```
[2021-08-17T10:30:06.093284+00:00] request.CRITICAL: Uncaught PHP Exception Twig\Error\RuntimeError: "An exception has been thrown during the rendering of a template ("Warning: Undefined array key "timestamp_rfc3339"")." at /app/vendor/symfony/web-profiler-bundle/Resources/views/Collector/logger.html.twig line 49 {"exception":"[object] (Twig\\Error\\RuntimeError(code: 0): An exception has been thrown during the rendering of a template (\"Warning: Undefined array key \"timestamp_rfc3339\"\"). at /app/vendor/symfony/web-profiler-bundle/Resources/views/Collector/logger.html.twig:49)\n[previous exception] [object] (ErrorException(code: 0): Warning: Undefined array key \"timestamp_rfc3339\" at /app/vendor/symfony/http-kernel/DataCollector/LoggerDataCollector.php:112)"} []
```

Found this issue on a new 5.4 project build today

Expected data shape is
```
array:7 [▼
  "timestamp" => Symfony\Component\VarDumper\Cloner\Data {#2810 ▶}
  "timestamp_rfc3339" => Symfony\Component\VarDumper\Cloner\Data {#2622 ▶}
  "message" => Symfony\Component\VarDumper\Cloner\Data {#2811 ▶}
  "priority" => Symfony\Component\VarDumper\Cloner\Data {#2812 ▶}
  "priorityName" => Symfony\Component\VarDumper\Cloner\Data {#2813 ▶}
  "context" => Symfony\Component\VarDumper\Cloner\Data {#2814 ▶}
  "channel" => Symfony\Component\VarDumper\Cloner\Data {#2815 ▶}
]
```

However I'm seeing this shape for `Please install the "intl" PHP extension for best performance.`
```
array:8 [▼
  "message" => Symfony\Component\VarDumper\Cloner\Data {#2905 ▶}
  "context" => Symfony\Component\VarDumper\Cloner\Data {#2717 ▶}
  "timestamp" => Symfony\Component\VarDumper\Cloner\Data {#2906 ▶}
  "priority" => Symfony\Component\VarDumper\Cloner\Data {#2907 ▶}
  "priorityName" => Symfony\Component\VarDumper\Cloner\Data {#2908 ▶}
  "channel" => Symfony\Component\VarDumper\Cloner\Data {#2909 ▶}
  "scream" => Symfony\Component\VarDumper\Cloner\Data {#2910 ▶}
  "errorCount" => Symfony\Component\VarDumper\Cloner\Data {#2911 ▶}
]
```
![image](https://user-images.githubusercontent.com/1097038/129744965-3cb18a81-5083-446d-af7e-d1209dde9eb5.png)

Commits
-------

967dee3 [HttpKernel] Fix timestamp_rfc3339 in LoggerDataCollector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stloyd @stof @fabpot
0