[DependencyInjection] Made the reference case insensitive #2811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The container is case insensitive so using capital letters in a reference made it fail in some cases when checking the dependencies. Closes symfony#2807
|
@stof: What about doing this fix in the 2.0 branch? |
|
oh, in fact I did it in 2.0. I just forgot to change the target of the PR. I will reopen it to 2.0 |
fabpot
added a commit
that referenced
this pull request
Dec 8, 2011
Commits ------- 2c3e9ad [DependencyInjection] Made the reference case insensitive Discussion ---------- [DependencyInjection] Made the reference case insensitive The container is case insensitive so using capital letters in a reference made it fail in some cases when checking the dependencies. Closes #2807 Replaces #2811 by targeting the good branch
fabpot
added a commit
that referenced
this pull request
Aug 23, 2021
…(carlcasbolt) This PR was merged into the 5.4 branch. Discussion ---------- [HttpKernel] Fix timestamp_rfc3339 in LoggerDataCollector Found that this was still needed for some log items to avoid an error in Profiler | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Ticket | Fixes #42622 | License | MIT Fix for the following error on Web Profiler when looking at error logs ``` [2021-08-17T10:30:06.093284+00:00] request.CRITICAL: Uncaught PHP Exception Twig\Error\RuntimeError: "An exception has been thrown during the rendering of a template ("Warning: Undefined array key "timestamp_rfc3339"")." at /app/vendor/symfony/web-profiler-bundle/Resources/views/Collector/logger.html.twig line 49 {"exception":"[object] (Twig\\Error\\RuntimeError(code: 0): An exception has been thrown during the rendering of a template (\"Warning: Undefined array key \"timestamp_rfc3339\"\"). at /app/vendor/symfony/web-profiler-bundle/Resources/views/Collector/logger.html.twig:49)\n[previous exception] [object] (ErrorException(code: 0): Warning: Undefined array key \"timestamp_rfc3339\" at /app/vendor/symfony/http-kernel/DataCollector/LoggerDataCollector.php:112)"} [] ``` Found this issue on a new 5.4 project build today Expected data shape is ``` array:7 [▼ "timestamp" => Symfony\Component\VarDumper\Cloner\Data {#2810 ▶} "timestamp_rfc3339" => Symfony\Component\VarDumper\Cloner\Data {#2622 ▶} "message" => Symfony\Component\VarDumper\Cloner\Data {#2811 ▶} "priority" => Symfony\Component\VarDumper\Cloner\Data {#2812 ▶} "priorityName" => Symfony\Component\VarDumper\Cloner\Data {#2813 ▶} "context" => Symfony\Component\VarDumper\Cloner\Data {#2814 ▶} "channel" => Symfony\Component\VarDumper\Cloner\Data {#2815 ▶} ] ``` However I'm seeing this shape for `Please install the "intl" PHP extension for best performance.` ``` array:8 [▼ "message" => Symfony\Component\VarDumper\Cloner\Data {#2905 ▶} "context" => Symfony\Component\VarDumper\Cloner\Data {#2717 ▶} "timestamp" => Symfony\Component\VarDumper\Cloner\Data {#2906 ▶} "priority" => Symfony\Component\VarDumper\Cloner\Data {#2907 ▶} "priorityName" => Symfony\Component\VarDumper\Cloner\Data {#2908 ▶} "channel" => Symfony\Component\VarDumper\Cloner\Data {#2909 ▶} "scream" => Symfony\Component\VarDumper\Cloner\Data {#2910 ▶} "errorCount" => Symfony\Component\VarDumper\Cloner\Data {#2911 ▶} ] ```  Commits ------- 967dee3 [HttpKernel] Fix timestamp_rfc3339 in LoggerDataCollector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The container is case insensitive so using capital letters in a reference
made it fail in some cases when checking the dependencies.
Closes #2807