8000 fix Process::run in windows, when php.exe resides within a folder with a space in it by Burgov · Pull Request #2814 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

fix Process::run in windows, when php.exe resides within a folder with a space in it #2814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix Process::run in windows, when php.exe resides within a folder with a space in it #2814

wants to merge 1 commit into from

Conversation

Burgov
Copy link
Contributor
@Burgov Burgov commented Dec 8, 2011

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes

Todo: please verify that this doesn't break anything in other platforms!

I was getting the following error when running the Symfony2 tests:

  1. Symfony\Tests\Component\BrowserKit\ClientTest::testInsulatedRequests
    RuntimeException: OUTPUT: ERROR OUTPUT: 'C:\Program' is not recognized as an internal or external command,
    operable program or batch file.

D:\workspace9\Symfony\src\Symfony\Component\BrowserKit\Client.php:294
D:\workspace9\Symfony\src\Symfony\Component\BrowserKit\Client.php:260
D:\workspace9\Symfony\tests\Symfony\Tests\Component\BrowserKit\ClientTest.php:298

This PR fixes that

@Burgov
8000
Copy link
Contributor Author
Burgov commented Dec 8, 2011

old PR: #2812

@Burgov
Copy link
Contributor Author
Burgov commented Dec 8, 2011

"This seems like the wrong place to fix it, since you're quoting the full command, it may be that you're including arguments in the process name. This escaping should be done beforehand IMO."

Seldaek: I'll try to figure out where this is best done

@kriswallsmith
Copy link
Contributor

Isn't this going to escape the entire command as one argument? I'm pretty sure we don't want that.

Please take a look at the ProcessBuilder class I've built in Assetic. Maybe we should copy that into this component.
https://github.com/kriswallsmith/assetic/blob/master/src/Assetic/Util/ProcessBuilder.php

@Burgov
Copy link
Contributor Author
Burgov commented Dec 8, 2011

I added a commit. Does this location seem better for it?

@stof
Copy link
Member
stof commented Dec 8, 2011

@kriswallsmith the ProcessBuilder probably deserves going in the component. You should do a PR.

@fabpot
Copy link
Member
fabpot commented Dec 17, 2011

#2902 introduced a ProcessBuilder class that does the fix "properly".

@fabpot fabpot closed this Dec 17, 2011
fabpot added a commit that referenced this pull request Aug 23, 2021
@fabpot
bug #42600 [HttpKernel] Fix timestamp_rfc3339 in LoggerDataCollector …
dabd127 
…(carlcasbolt)

This PR was merged into the 5.4 branch.

Discussion
----------

[HttpKernel] Fix timestamp_rfc3339 in LoggerDataCollector

Found that this was still needed for some log items to avoid an error in Profiler

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Ticket | Fixes #42622
| License       | MIT

Fix for the following error on Web Profiler when looking at error logs

```
[2021-08-17T10:30:06.093284+00:00] request.CRITICAL: Uncaught PHP Exception Twig\Error\RuntimeError: "An exception has been thrown during the rendering of a template ("Warning: Undefined array key "timestamp_rfc3339"")." at /app/vendor/symfony/web-profiler-bundle/Resources/views/Collector/logger.html.twig line 49 {"exception":"[object] (Twig\\Error\\RuntimeError(code: 0): An exception has been thrown during the rendering of a template (\"Warning: Undefined array key \"timestamp_rfc3339\"\"). at /app/vendor/symfony/web-profiler-bundle/Resources/views/Collector/logger.html.twig:49)\n[previous exception] [object] (ErrorException(code: 0): Warning: Undefined array key \"timestamp_rfc3339\" at /app/vendor/symfony/http-kernel/DataCollector/LoggerDataCollector.php:112)"} []
```

Found this issue on a new 5.4 project build today

Expected data shape is
```
array:7 [▼
  "timestamp" => Symfony\Component\VarDumper\Cloner\Data {#2810 ▶}
  "timestamp_rfc3339" => Symfony\Component\VarDumper\Cloner\Data {#2622 ▶}
  "message" => Symfony\Component\VarDumper\Cloner\Data {#2811 ▶}
  "priority" => Symfony\Component\VarDumper\Cloner\Data {#2812 ▶}
  "priorityName" => Symfony\Component\VarDumper\Cloner\Data {#2813 ▶}
  "context" => Symfony\Component\VarDumper\Cloner\Data {#2814 ▶}
  "channel" => Symfony\Component\VarDumper\Cloner\Data {#2815 ▶}
]
```

However I'm seeing this shape for `Please install the "intl" PHP extension for best performance.`
```
array:8 [▼
  "message" => Symfony\Component\VarDumper\Cloner\Data {#2905 ▶}
  "context" => Symfony\Component\VarDumper\Cloner\Data {#2717 ▶}
  "timestamp" => Symfony\Component\VarDumper\Cloner\Data {#2906 ▶}
  "priority" => Symfony\Component\VarDumper\Cloner\Data {#2907 ▶}
  "priorityName" => Symfony\Component\VarDumper\Cloner\Data {#2908 ▶}
  "channel" => Symfony\Component\VarDumper\Cloner\Data {#2909 ▶}
  "scream" => Symfony\Component\VarDumper\Cloner\Data {#2910 ▶}
  "errorCount" => Symfony\Component\VarDumper\Cloner\Data {#2911 ▶}
]
```
![image](https://user-images.githubusercontent.com/1097038/129744965-3cb18a81-5083-446d-af7e-d1209dde9eb5.png)

Commits
-------

967dee3 [HttpKernel] Fix timestamp_rfc3339 in LoggerDataCollector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Burgov @kriswallsmith @stof @fabpot
0