8000 Update da translations by c960657 · Pull Request #26801 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Update da translations #26801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Update da translations #26801

merged 1 commit into from
Apr 4, 2018

Conversation

c960657
Copy link
Contributor
@c960657 c960657 commented Apr 4, 2018
Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

The Danish translations have several serious errors. This PR adjusts to official Danish orthography, and updates some texts for internal consistency and to better reflect the original English text.

@fabpot
Copy link
Member
fabpot commented Apr 4, 2018

Thank you @c960657.

@fabpot fabpot merged commit d0ea26b into symfony:2.7 Apr 4, 2018
fabpot added a commit that referenced this pull request Apr 4, 2018
This PR was merged into the 2.7 branch.

Discussion
----------

Update da translations

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

The Danish translations have several serious errors. This PR adjusts to official Danish orthography, and updates some texts for internal consistency and to better reflect the original English text.

Commits
-------

d0ea26b Update da translations
</trans-unit>
<trans-unit id="18">
<source>This value should be {{ limit }} or less.</source>
<target>Værdien skal være {{ limit }} eller mindre.</target>
</trans-unit>
<trans-unit id="19">
<source>This value is too long. It should have {{ limit }} character or less.|This value is too long. It should have {{ limit }} characters or less.</source>
<target>Værdien er for lang. Den skal have {{ limit }} bogstaver eller mindre.</target>
<target>Værdien er for lang. Den må højst indeholde {{ limit }} tegn.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The English message applies pluralization based on {{ limit }}. Should it be done also in Danish or would both variants be the same ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, some Danish words, including “tegn”, are the same in singular and plural form. It sounds confusing, but somehow it isn't :-)

@c960657 c960657 deleted the translation-da branch April 5, 2018 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0