8000 [Config] Handle nullable node name + fix inheritdocs by ro0NL · Pull Request #26335 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Config] Handle nullable node name + fix inheritdocs #26335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

[Config] Handle nullable node name + fix inheritdocs #26335

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0d343c9
[Config] Handle nullable node name
ro0NL Feb 27, 2018
986ae4c
fix inheritdocs
ro0NL Feb 27, 2018
bc1c945
fix BaseNode inheritdoc
ro0NL Feb 27, 2018
6f1db4c
use cast
ro0NL Feb 27, 2018
03ea776
fix all the inheritdocs
ro0NL Feb 27, 2018
f1eb6ec
fix @throws
ro0NL Mar 1, 2018
be2a65d
Update NodeInterface.php
ro0NL Mar 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix @throws
  • Loading branch information
@ro0NL
ro0NL committed Mar 1, 2018
commit f1eb6ecbbf4a5da4670975ec255a224086331449
11 changes: 7 additions & 4 deletions src/Symfony/Component/Config/Definition/NodeInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@

namespace Symfony\Component\Config\Definition;

use Symfony\Component\Config\Definition\Exception\Exception;
use Symfony\Component\Config\Definition\Exception\ForbiddenOverwriteException;
use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
use Symfony\Component\Config\Definition\Exception\InvalidTypeException;

/**
* Common Interface among all nodes.
Expand Down Expand Up @@ -68,6 +68,8 @@ public function getDefaultValue();
* @param mixed $value Value to normalize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe A value to normalize ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in fact.. i think i should revert this one as the interface was already using different syntax:

https://github.com/symfony/symfony/pull/26335/files#diff-41913ce7a681852774440044e2c091bdR92

*
* @return mixed The normalized value
*
* @throws InvalidTypeException if the value type is invalid
*/
public function normalize($value);

Expand All @@ -79,7 +81,8 @@ public function normalize($value);
*
* @return mixed The merged value
*
* @throws ForbiddenOverwriteException
* @throws ForbiddenOverwriteException if the configuration path cannot be overwritten
* @throws InvalidTypeException if the value type is invalid
*/
public function merge($leftSide, $rightSide);

Expand All @@ -90,8 +93,8 @@ public function merge($leftSide, $rightSide);
*
* @return mixed The finalized value
*
* @throws Exception
* @throws InvalidConfigurationException
* @throws InvalidTypeException if the value type is invalid
* @throws InvalidConfigurationException if the value is invalid configuration
*/
public function finalize($value);
}
0