8000 [Config] Handle nullable node name + fix inheritdocs by ro0NL · Pull Request #26335 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Config] Handle nullable node name + fix inheritdocs #26335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

[Config] Handle nullable node name + fix inheritdocs #26335

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0d343c9
[Config] Handle nullable node name
ro0NL Feb 27, 2018
986ae4c
fix inheritdocs
ro0NL Feb 27, 2018
bc1c945
fix BaseNode inheritdoc
ro0NL Feb 27, 2018
6f1db4c
use cast
ro0NL Feb 27, 2018
03ea776
fix all the inheritdocs
ro0NL Feb 27, 2018
f1eb6ec
fix @throws
ro0NL Mar 1, 2018
be2a65d
Update NodeInterface.php
ro0NL Mar 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix inheritdocs
  • Loading branch information
@ro0NL
ro0NL committed Feb 27, 2018
commit 986ae4cc1e03969a3069d8dc300e9e5adbf2fee4
18 changes: 3 additions & 15 deletions src/Symfony/Component/Config/Definition/Builder/ArrayNodeDefinition.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,15 @@ public function __construct($name, NodeParentInterface $parent = null)
}

/**
* Sets a custom children builder.
* {@inheritdoc}
*/
public function setBuilder(NodeBuilder $builder)
{
$this->nodeBuilder = $builder;
}

/**
* Returns a builder to add children nodes.
*
* @return NodeBuilder
* {@inheritdoc}
*/
public function children()
{
Expand Down Expand Up @@ -306,17 +304,7 @@ public function normalizeKeys($bool)
}

/**
* Appends a node definition.
*
* $node = new ArrayNodeDefinition()
* ->children()
* ->scalarNode('foo')->end()
* ->scalarNode('baz')->end()
* ->end()
* ->append($this->getBarNodeDefinition())
* ;
*
* @return $this
* {@inheritdoc}
*/
public function append(NodeDefinition $node)
{
Expand Down
23 changes: 23 additions & 0 deletions src/Symfony/Component/Config/Definition/Builder/ParentNodeDefinitionInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,32 @@
*/
interface ParentNodeDefinitionInterface
{
/**
* Returns a builder to add children nodes.
*
* @return NodeBuilder
*/
public function children();

/**
* Appends a node definition.
*
* Usage:
*
* $node = $parentNode
* ->children()
* ->scalarNode('foo')->end()
* ->scalarNode('baz')->end()
* ->append($this->getBarNodeDefinition())
* ->end()
* ;
*
* @return $this
*/
public function append(NodeDefinition $node);

/**
* Sets a custom children builder.
*/
public function setBuilder(NodeBuilder $builder);
}
3 changes: 0 additions & 3 deletions src/Symfony/Component/Config/Definition/VariableNode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@ class VariableNode extends BaseNode implements PrototypeNodeInterface
protected $defaultValue;
protected $allowEmptyValue = true;

/**
* {@inheritdoc}
*/
public function setDefaultValue($value)
{
$this->defaultValueSet = true;
Expand Down
0