8000 [Config] Handle nullable node name + fix inheritdocs by ro0NL · Pull Request #26335 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Config] Handle nullable node name + fix inheritdocs #26335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

[Config] Handle nullable node name + fix inheritdocs #26335

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0d343c9
[Config] Handle nullable node name
ro0NL Feb 27, 2018
986ae4c
fix inheritdocs
ro0NL Feb 27, 2018
bc1c945
fix BaseNode inheritdoc
ro0NL Feb 27, 2018
6f1db4c
use cast
ro0NL Feb 27, 2018
03ea776
fix all the inheritdocs
ro0NL Feb 27, 2018
f1eb6ec
fix @throws
ro0NL Mar 1, 2018
be2a65d
Update NodeInterface.php
ro0NL Mar 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix all the inheritdocs
  • Loading branch information
@ro0NL
ro0NL committed Feb 27, 2018
commit 03ea77657a2448d620e7beb1503bf19bcfdc2958
14 changes: 3 additions & 11 deletions src/Symfony/Component/Config/Definition/ArrayNode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,31 +150,23 @@ public function setIgnoreExtraKeys($boolean)
}

/**
* Sets the node Name.
*
* @param string $name The node's name
* {@inheritdoc}
*/
public function setName($name)
{
$this->name = $name;
}

/**
* Checks if the node has a default value.
*
* @return bool
* {@inheritdoc}
*/
public function hasDefaultValue()
{
return $this->addIfNotSet;
}

/**
* Retrieves the default value.
*
* @return array The default value
*
* @throws \RuntimeException if the node has no default value
* {@inheritdoc}
*/
public function getDefaultValue()
{
Expand Down
8 changes: 2 additions & 6 deletions src/Symfony/Component/Config/Definition/PrototypedArrayNode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,7 @@ public function setDefaultValue($value)
}

/**
* Checks if the node has a default value.
*
* @return bool
* {@inheritdoc}
*/
public function hasDefaultValue()
{
Expand All @@ -126,12 +124,10 @@ public function setAddChildrenIfNoneSet($children = array('defaults'))
}

/**
* Retrieves the default value.
* {@inheritdoc}
*
* The default value could be either explicited or derived from the prototype
* default value.
*
* @return array The default value
*/
public function getDefaultValue()
{
Expand Down
0