Fix - #17676 (backport #17919 to 2.3) #17946
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #17676 |
| License | MIT |
| Doc PR |
Also verify edge case where no last-modified header is available
…istan) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes symfony#17074). Discussion ---------- Fix constraint validator alias being required | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#16805 | License | MIT | Doc PR | symfony/symfony-docs#6055 This is my first contribution, so everything might not be in perfect order. Follow-up of symfony#16841 on the right branch. Commits ------- 5136c30 Fix constraint validator alias being required
…olas-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [Console] Fix escaping of trailing backslashes | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#17908 | License | MIT | Doc PR | - Commits ------- 44ae785 [Console] Fix escaping of trailing backslashes
…nicolas-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [ci] clone with depth=1 to kill push-forced PRs | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | - | License | MIT | Doc PR | - As documented in travis-ci/travis-ci#4575 (comment), setting a clone depth of 1 will make push-forced PRs to fail quickly so that our CI won't spend too much time on them. Commits ------- 562d4d6 [ci] clone with depth=1 to kill push-forced PRs
…ehavior with if-range header (bburnichon) This PR was merged into the 2.3 branch. Discussion ---------- [HttpFoundation] Fix BinaryFileResponse incorrect behavior with if-range header | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#16540 | License | MIT | Doc PR | - Commits ------- aaad5bd Add check on If-Range header
…" (bouland) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes symfony#17542). Discussion ---------- ChoiceFormField of type "select" could be "disabled" Hi, New PR to add tests from the closed PR symfony#15952 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 576c4b9 ChoiceFormField of type "select" could be "disabled"
This PR was merged into the 2.3 branch. Discussion ---------- Update contributing docs | Q | A | ------------- | --- | Branch | 2.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I propose adding the branch to the pull request template so that submitters have some hint about the branch selection workflow, and so that we can edit it for mergers. I'd also like to add a link to the "running tests" doc, which made me rewrite the full contributing file, with links to the sections of the contributing documentation. Commits ------- 852f999 Update contributing docs
…Manager 2.x by detecting proxy features
|
Of course I get the base branch wrong -.- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.