10000 Update contributing docs by nicolas-grekas · Pull Request #17916 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Update contributing docs #17916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2016
Merged

Update contributing docs #17916

merged 1 commit into from
Feb 28, 2016

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch 2.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

I propose adding the branch to the pull request template so that submitters have some hint about the branch selection workflow, and so that we can edit it for mergers.

I'd also like to add a link to the "running tests" doc, which made me rewrite the full contributing file, with links to the sections of the contributing documentation.

@fabpot
Copy link
Member
fabpot commented Feb 26, 2016

👍

1 similar comment
@dunglas
Copy link
Member
dunglas commented Feb 26, 2016

👍

@xabbuh
Copy link
Member
xabbuh commented Feb 27, 2016

👍

Status: Reviewed

@fabpot
Copy link
Member
fabpot commented Feb 28, 2016

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 852f999 into symfony:2.3 Feb 28, 2016
fabpot added a commit that referenced this pull request Feb 28, 2016
This PR was merged into the 2.3 branch.

Discussion
----------

Update contributing docs

| Q             | A
| ------------- | ---
| Branch        | 2.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

I propose adding the branch to the pull request template so that submitters have some hint about the branch selection workflow, and so that we can edit it for mergers.

I'd also like to add a link to the "running tests" doc, which made me rewrite the full contributing file, with links to the sections of the contributing documentation.

Commits
-------

852f999 Update contributing docs
@nicolas-grekas nicolas-grekas deleted the contrib-br branch February 29, 2016 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0