Conversation
Hi, A select could be "globaly" disabled not only one of its options. http://www.w3schools.com/tags/att_select_disabled.asp
|
Imo this deserves a test to avoid regressions. Status: Needs work |
|
I agree with @xabbuh |
|
@bouland Can you work on adding some unit tests? |
|
I was a little lost, I didn't understand what was expected from me : |
|
@bouland Any news on this one? |
|
Well i have not taken time to write the test. |
|
Could you give me push access to the PR branch |
|
I can't. The best would be to close this PR and open a new one. |
|
@bouland By the way, how did you end up with having a |
|
When i want to write a WebTestCase which submit a Form with a select with attribute disabled. it calls public function Client::submit(Form $form, array $values = array())
{
$form->setValues($values);
return $this->request($form->getMethod(), $form->getUri(), $form->getPhpValues(), $form->getPhpFiles());
}then the test public function Form::getValues()
{
$values = array();
foreach ($this->fields->all() as $name => $field) {
if ($field->isDisabled()) {
continue;
} |
…and) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #17542). Discussion ---------- ChoiceFormField of type "select" could be "disabled" Hi, New PR to add tests from the closed PR #15952 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 576c4b9 ChoiceFormField of type "select" could be "disabled"
This PR was submitted on the symfony/dom-crawler read-only repository by @bouland and moved automatically to the main Symfony repository (closes symfony/dom-crawler#20).
Hi,
A select could be "globaly" disabled not only one of its options.
http://www.w3schools.com/tags/att_select_disabled.asp