8000 [travis] Kill tests when a new commit has been pushed by nicolas-grekas · Pull Request #14047 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[travis] Kill tests when a new commit has been pushed #14047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2015
Merged

[travis] Kill tests when a new commit has been pushed #14047

merged 1 commit into from
Mar 26, 2015

Conversation

nicolas-grekas
Copy link
Member
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

stof
stof reviewed Mar 25, 2015
View reviewed changes
.travis.yml
@@ -26,6 +26,8 @@ env:
- SYMFONY_DEPRECATIONS_HELPER=weak

before_install:
- if [[ "$TRAVIS_PULL_REQUEST" != "false" ]]; then git fetch origin "refs/pull/$TRAVIS_PULL_REQUEST/head"; else git fetch origin "$TRAVIS_BRANCH"; fi;
- if [[ "$TRAVIS_COMMIT" != `git rev-parse FETCH_HEAD` ]]; then exit 1; fi;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should probbaly output a message explaining why this has exited

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not much inspired, is it ok for you now?

@stof
Copy link
Member
stof commented Mar 25, 2015

👍

@nicolas-grekas nicolas-grekas force-pushed the travis-kill-push branch 3 times, most recently from 574147d to a4b03c7 Compare March 25, 2015 12:57
@nicolas-grekas
Copy link
Member Author

I tried to find a way to "cancel" the build but it looks like it's not possible, so we must exit 1 which puts the build in "errored" mode.

@fabpot
Copy link
Member
fabpot commented Mar 26, 2015

Thank you @nicolas-grekas.

@fabpot fabpot merged commit e29f74e into symfony:2.3 Mar 26, 2015
fabpot added a commit that referenced this pull request Mar 26, 2015
@fabpot
minor #14047 [travis] Kill tests when a new commit has been pushed (n…
d5673c2 
…icolas-grekas)

This PR was merged into the 2.3 branch.

Discussion
----------

[travis] Kill tests when a new commit has been pushed

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

e29f74e [travis] Kill tests when a new commit has been pushed
@nicolas-grekas nicolas-grekas deleted the travis-kill-push branch March 27, 2015 16:05
@xabbuh xabbuh mentioned this pull request Mar 29, 2015
Merged
@nicolas-grekas nicolas-grekas mentioned this pull request Mar 31, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @stof @fabpot @TomasVotruba
0