[travis] Revert tests cancellations and don't fail if memcached is not avail #14141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e27187 to
709494f
Compare
|
So, I reverted #14047 and added a check to not fail if memcached can't be installed. |
| @@ -26,15 +26,12 @@ env: | |||
| - SYMFONY_DEPRECATIONS_HELPER=weak | |||
|
|
|||
| before_install: | |||
| - if [[ "$TRAVIS_PULL_REQUEST" != "false" ]]; then git fetch origin "refs/pull/$TRAVIS_PULL_REQUEST/merge"; else git fetch origin "$TRAVIS_BRANCH"; fi; | |||
| - if [[ "$TRAVIS_COMMIT" != `git rev-parse FETCH_HEAD` ]]; then echo "Pull request or branch commit hash has changed, aborting!"; exit 1; fi; | |||
There was a problem hiding this comment.
Did you figure out what actually happened on Travis to make this fail?
There was a problem hiding this comment.
Somehow: they have $TRAVIS_COMMIT hash that do not exist anymore in the main repos. I suspect this is related to github doing merges all the time in refs/pull/*/merge, eveytime we merge something in the target branch.
709494f to
7441955
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Apr 1, 2015
…mcached is not avail (nicolas-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [travis] Revert tests cancellations and don't fail if memcached is not avail | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I don't understand how travis gets its $TRAVIS_COMMIT, but this should make things stable again. Commits ------- 7441955 [travis] Fix tests cancellations
|
Travis should be back to green now that this is merged, please rebase your PRs pull-requesters |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't understand how travis gets its $TRAVIS_COMMIT, but this should make things stable again.