8000 [Configuration] improve description for ignoreExtraKeys on ArrayNodeDefinition by cordoval · Pull Request #14101 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Configuration] improve description for ignoreExtraKeys on ArrayNodeDefinition #14101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2015
Merged

[Configuration] improve description for ignoreExtraKeys on ArrayNodeDefinition #14101

merged 1 commit into from
Mar 30, 2015

Conversation

cordoval
Copy link
Contributor
Q A
Bug Fix? y
New Feature? n
BC Breaks? n
Deprecations? n
Tests Pass? y
Fixed Tickets #13957
License MIT
Doc PR

@cordoval cordoval closed this Mar 29, 2015
@cordoval cordoval reopened this Mar 29, 2015
@cordoval
Copy link
Contributor Author

anyone on why travis is failing in that way "Pull request or branch commit hash has changed, aborting!" ?

@xabbuh
Copy link
Member
xabbuh commented Mar 29, 2015

@cordoval Since #14047 Travis builds are stopped for a PR when there are more recent commits pushed to it. Actually, only the build status of the last pushed commit is of interest.

@xabbuh
Copy link
Member
xabbuh commented Mar 29, 2015

Just curious: Did you push another commit which you removed again later?

@cordoval
Copy link
Contributor Author

I did not @xabbuh

@fabpot
Copy link
Member
fabpot commented Mar 30, 2015

Thank you @cordoval.

@fabpot fabpot merged commit b735022 into symfony:2.3 Mar 30, 2015
fabpot added a commit that referenced this pull request Mar 30, 2015
@fabpot
minor #14101 [Configuration] improve description for ignoreExtraKeys …
9215c22 
…on ArrayNodeDefinition (cordoval)

This PR was merged into the 2.3 branch.

Discussion
----------

[Configuration] improve description for ignoreExtraKeys on ArrayNodeDefinition

|Q            |A  |
|---          |---|
|Bug Fix?     |y  |
|New Feature? |n  |
|BC Breaks?   |n  |
|Deprecations?|n  |
|Tests Pass?  |y  |
|Fixed Tickets| #13957  |
|License      |MIT|
|Doc PR       |   |

Commits
-------

b735022 [Configuration] improve description for ignoreExtraKeys on ArrayNodeDefinition
@cordoval cordoval deleted the fix-docblock-configuration-array-node branch March 30, 2015 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cordoval @xabbuh @fabpot
0