[Validator] Fixed StaticMethodLoaderTest to actually test something #12017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c99333e to
b5ef7ce
Compare
b5ef7ce to
1b1303a
Compare
|
👍 |
|
Thank you @webmozart. |
fabpot
added a commit
that referenced
this pull request
Sep 25, 2014
…t something (webmozart) This PR was merged into the 2.3 branch. Discussion ---------- [Validator] Fixed StaticMethodLoaderTest to actually test something | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This test is not testing anything, except for whether PHP throws a strict standards error when invalid code is loaded. I disabled error reporting for this test, so that the actual functionality (ignoring static+abstract functions) is tested. Commits ------- 1b1303a [Validator] Fixed StaticMethodLoaderTest to actually test something
|
Does PHPUnit reset the error reporting level between each test ? |
|
@stof This is done manually in the test case (see |
|
ah indeed, I forgot it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is not testing anything, except for whether PHP throws a strict standards error when invalid code is loaded.
I disabled error reporting for this test, so that the actual functionality (ignoring static+abstract functions) is tested.