8000 [Validator] Fixed StaticMethodLoaderTest to actually test something by webmozart · Pull Request #12017 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Fixed StaticMethodLoaderTest to actually test something #12017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2014
Merged

[Validator] Fixed StaticMethodLoaderTest to actually test something #12017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Validator] Fixed StaticMethodLoaderTest to actually test something
  • Loading branch information
@webmozart
webmozart committed Sep 24, 2014
commit 1b1303a8d848df84651a50762dc534915eaedc09
2 changes: 1 addition & 1 deletion ...ing/Loader/AbstractMethodStaticLoader.php → ...ing/Loader/AbstractStaticMethodLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

use Symfony\Component\Validator\Mapping\ClassMetadata;

abstract class AbstractMethodStaticLoader
abstract class AbstractStaticMethodLoader
{
abstract public static function loadMetadata(ClassMetadata $metadata);
}
21 changes: 9 additions & 12 deletions src/Symfony/Component/Validator/Tests/Mapping/Loader/StaticMethodLoaderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,22 +90,19 @@ public function testLoadClassMetadataInAbstractClasses()

public function testLoadClassMetadataIgnoresAbstractMethods()
{
error_reporting(E_ALL | E_STRICT);
// Disable error reporting, as AbstractStaticMethodLoader produces a
// strict standards error
error_reporting(0);

$loader = new StaticMethodLoader('loadMetadata');
$caught = false;
try {
include __DIR__.'/AbstractMethodStaticLoader.php';
} catch (\Exception $e) {
// catching the PHP notice that is converted to an exception by PHPUnit
$caught = true;
if (0 !== error_reporting()) {
$this->markTestSkipped('Could not disable error reporting');
}

if (!$caught) {
$this->fail('AbstractMethodStaticLoader should produce a strict standard error.');
}
include __DIR__.'/AbstractStaticMethodLoader.php';

$metadata = new ClassMetadata(__NAMESPACE__.'\AbstractMethodStaticLoader');
$metadata = new ClassMetadata(__NAMESPACE__.'\AbstractStaticMethodLoader');

$loader = new StaticMethodLoader('loadMetadata');
$loader->loadClassMetadata($metadata);

$this->assertCount(0, $metadata->getConstraints());
Expand Down
0