8000 DOC: Correct links and typos in 6.6 Random Projections by star1327p · Pull Request #30848 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC: Correct links and typos in 6.6 Random Projections #30848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2025
Merged

DOC: Correct links and typos in 6.6 Random Projections #30848

merged 1 commit into from
Feb 18, 2025

Conversation

star1327p
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Correct links and typos in 6.6 Random Projections.

Ella Bingham and Heikki Mannila. 2001. Random projection in dimensionality reduction: applications to image and text data.
https://cs-people.bu.edu/evimaria/cs565/kdd-rp.pdf

Sanjoy Dasgupta and Anupam Gupta, 1999. An elementary proof of the Johnson-Lindenstrauss Lemma.
https://cseweb.ucsd.edu/~dasgupta/papers/jl.pdf

Any other comments?

@github-actions GitHub Actions
Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 8fdebc8. Link to the linter CI: here

@lesteve
Copy link
Member
lesteve commented Feb 18, 2025 •
edited
Loading

Thanks a lot, merging this one!

Just curious:

  • are you discovering these broken links while browsing the doc? Or do you have a way to detect broken links somehow?
  • do you think all citeseerx links are broken (maybe citeseerx changed something and we did not realise 🤔)?

@lesteve lesteve merged commit 6d14a58 into scikit-learn:main Feb 18, 2025
36 checks passed
@star1327p
Copy link
Contributor Author
star1327p commented Feb 18, 2025 •
edited
Loading

@lesteve Thank you for your feedback!

  • are you discovering these broken links while browsing the doc? Or do you have a way to detect broken links somehow?

I discovered these broken links while browsing the doc. It is possible to run sphinx's linkcheck in CI and automatically write out the failures to an issue .github/workflows/broken-linkcheck.yml. But I am not familiar with the process and will need help to do so.

  • do you think all citeseerx links are broken (maybe citeseerx changed something and we did not realise 🤔)?

Yes, I searched citeseerx in the scikit-learn repo and discovered that most citeseerx links don't work anymore. When I opened #30741, I thought it was a one-off incident. But now I believe that citeseerx has changed their URL structure.

For example, this link does not work:
https://citeseerx.ist.psu.edu/doc_view/pid/3dc9d625404fdfef6eaccc3babddefe4c176abd4

But this link with the same DOI works:
https://citeseerx.ist.psu.edu/document?repid=rep1&type=pdf&doi=3dc9d625404fdfef6eaccc3babddefe4c176abd4

@lesteve
Copy link
Member
lesteve commented Feb 19, 2025 •
edited
Loading

Thanks a lot for the info 🙏!

I guess fixing the citeseer links would be more than welcome.

About doing make linkcheck regularly and possibly open issues automatically, if you know or find a repo that does it, I would be curious to look at the setup more closely to gauge whether it is worth it or not.

In the past we have done it manually from time to time for example in #25024 and #23631.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesteve lesteve lesteve approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@star1327p @lesteve
0