8000 DOC Update reference link in linear_model.rst by star1327p · Pull Request #30741 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

DOC Update reference link in linear_model.rst #30741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

star1327p
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Update reference link of Tristan Fletcher: Relevance Vector Machines Explained

New link:
https://static1.squarespace.com/static/58851af9ebbd1a30e98fb283/t/58902f4a6b8f5ba2ed9d3bfe/1485844299331/RVM+Explained.pdf

Old link does not work.
https://citeseerx.ist.psu.edu/doc_view/pid/3dc9d625404fdfef6eaccc3babddefe4c176abd4

Any other comments?

Copy link
github-actions bot commented Jan 31, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: a971f98. Link to the linter CI: here

@betatim
Copy link
Member
betatim commented Jan 31, 2025

Thanks for taking the time to notice and help fix broken links! The citeseerx link doesn't work for me either.

How did you find the PDF on squarespace? Is it part of a well known repository for journal articles? At first glance it isn't obvious if this is an "official" copy/hosting of this article or not. I don't think we want to link to "some random person's" squarespace upload, as the chances are that it will go away very soon or maybe was uploaded there from somewhere else.

Overall, if it isn't some kind of reputable/well known journal article repository it might be better to not link to it.

What do others think?

@betatim
Copy link
Member
betatim commented Jan 31, 2025

I found https://www.tristanfletcher.co.uk/tutorials by googling for the author/the paper. Maybe this is a better place to link to? The downside is that it isn't a direct link to the article.

The PDF linked from the page has a URL that is on squarepsace

@star1327p
Copy link
Contributor Author
star1327p commented Feb 1, 2025

@betatim Thank you for investigating this! I eventually found the new Citeseerx link that works, so I replaced the old link with this one instead.

https://citeseerx.ist.psu.edu/document?repid=rep1&type=pdf&doi=3dc9d625404fdfef6eaccc3babddefe4c176abd4

@lesteve
Copy link
Member
lesteve commented Feb 5, 2025

Both CI failures were intermittent, I restarted them, one was due to intermittent HTTP 403 on Figshare #30761.

@lesteve lesteve enabled auto-merge (squash) February 5, 2025 16:51
@lesteve
Copy link
Member
lesteve commented Feb 5, 2025

Thanks for your PR, I enabled auto-merge so this will be merged when CI is green.

@lesteve lesteve merged commit 6e7731f into scikit-learn:main Feb 5, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0